Skip to content

Conversation

@estliu
Copy link

@estliu estliu commented Nov 12, 2025

Signed-off-by: estella.liu <[email protected]>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. contribution This PR is from a community contributor. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 12, 2025
@estliu estliu changed the title fix Update GRPC module Nov 12, 2025
@estliu
Copy link
Author

estliu commented Nov 12, 2025

/assign

@estliu
Copy link
Author

estliu commented Nov 12, 2025

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 12, 2025

@estliu: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@estliu estliu removed their assignment Nov 12, 2025
@estliu
Copy link
Author

estliu commented Nov 12, 2025

/assign 5kbpers

@estliu
Copy link
Author

estliu commented Nov 12, 2025

@estliu
Copy link
Author

estliu commented Nov 12, 2025

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 12, 2025

@estliu: GitHub didn't allow me to assign the following users: disksing, ekexium, gengliqi, glorv, hicqu, hunterlxt, innerr, iosmanthus, crazycs520, imtbkcat.

Note that only tikv members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @crazycs520 @disksing @ekexium @gengliqi @glorv @hicqu @hunterlxt @imtbkcat @innerr @iosmanthus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@estliu
Copy link
Author

estliu commented Nov 12, 2025

/assign @jackysp @kennytm @Little-Wallace @liuzix @lonng @LykxSassinator @lysu @marsishandsome @MyonKeminta @niedhui

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 12, 2025

@estliu: GitHub didn't allow me to assign the following users: MyonKeminta, jackysp, Little-Wallace, lonng, lysu, marsishandsome, niedhui, kennytm, liuzix, LykxSassinator.

Note that only tikv members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @jackysp @kennytm @Little-Wallace @liuzix @lonng @LykxSassinator @lysu @marsishandsome @MyonKeminta @niedhui

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@estliu
Copy link
Author

estliu commented Nov 12, 2025

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 12, 2025

@estliu: GitHub didn't allow me to assign the following users: NingLin-P, nrc, overvenus, sticnarf, sunxiaoguang, tabokie, TennyZhuang, pingyu, skyzh, SpadeA-Tang.

Note that only tikv members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @NingLin-P @nrc @overvenus @pingyu @skyzh @SpadeA-Tang @sticnarf @sunxiaoguang @tabokie @TennyZhuang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@estliu
Copy link
Author

estliu commented Nov 12, 2025

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 12, 2025

@estliu: GitHub didn't allow me to assign the following users: zhangjinpeng87, zhongzc, zhouqiang-cl, zyguan, YuJuncen, tonyxuqqi, yiwu-arbug, you06, youjiali1995.

Note that only tikv members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @tonyxuqqi @yiwu-arbug @you06 @youjiali1995 @YuJuncen @zhangjinpeng87 @zhongzc @zhouqiang-cl @zyguan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 13, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, estliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-13 01:45:46.199837405 +0000 UTC m=+925795.642867284: ☑️ agreed by bufferflies.

@ti-chi-bot ti-chi-bot bot added the approved label Nov 13, 2025
@kennytm
Copy link

kennytm commented Nov 13, 2025

  • We already have an ongoing PR to upgrade the gRPC dependency in upgrade grpc to v1.73 #1779.

  • Also, we normally don't expect contribution directly to the tidb-8.5 branch. New changes should be based on the master branch, and they will be backported to tidb-X.Y branches when deemed necessary.

@kennytm kennytm added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.