Skip to content

update pd client and kvproto #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 7 commits into from
Dec 15, 2025
Merged

update pd client and kvproto #1821

ti-chi-bot merged 7 commits into from
Dec 15, 2025

Conversation

@lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Dec 15, 2025 •
edited
Loading

  1. update pd client to 6cebb3314abe, which is the commit before pd upgrade to go 1.25
  2. add interfaces: SetGlobalGCBarrier、DeleteGlobalGCBarrier、GetAllKeyspacesGCStates
  3. replace tidb with my tidb, which is base a165d9fd7c01 mockstore: add mock for gcStatesClient pingcap/tidb#65038
  4. add nolint:staticcheck for UpdateGCSafePoint

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2025
@lhy1024 lhy1024 force-pushed the update-pd3 branch 2 times, most recently from abe24de to 265b962 Compare December 15, 2025 04:51
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 15, 2025
@lhy1024
use my tidb
0a3ff8f 
Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 15, 2025
@lhy1024
add //nolint:staticcheck
e5e804b 
Signed-off-by: lhy1024 <[email protected]>
@lhy1024
triger
8887703 
Signed-off-by: lhy1024 <[email protected]>
@lhy1024
triger
577dd9a 
Signed-off-by: lhy1024 <[email protected]>
@lhy1024
triger
11d9c69 
Signed-off-by: lhy1024 <[email protected]>
@lhy1024
triger
db07964 
Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 15, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, ekexium

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 15, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-15 12:02:51.691272521 +0000 UTC m=+1474516.505050083: ☑️ agreed by cfzjywxk.
  • 2025-12-15 12:05:05.719438368 +0000 UTC m=+1474650.533215940: ☑️ agreed by ekexium.

@ti-chi-bot ti-chi-bot bot merged commit 0175881 into tikv:master Dec 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@ekexium ekexium ekexium approved these changes

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lhy1024 @cfzjywxk @ekexium