Skip to content

fix inconsistent store pointers between the region-cache and store-cache #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AndreMouche wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix inconsistent store pointers between the region-cache and store-cache #1825

AndreMouche wants to merge 5 commits into from
+105 −104

Conversation

@AndreMouche
Copy link
Member

@AndreMouche AndreMouche commented Dec 17, 2025

fix #1823

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign brson for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 17, 2025
@AndreMouche
fix tests
752fd7e 
Signed-off-by: AndreMouche <[email protected]>
@AndreMouche
fix potential deadlock
2ab0333 
Signed-off-by: AndreMouche <[email protected]>
@AndreMouche
fix potential deadlock
64a5ecf 
Signed-off-by: AndreMouche <[email protected]>
@AndreMouche AndreMouche force-pushed the store_cache_update_addr branch from 0e3e6c4 to 64a5ecf Compare December 17, 2025 18:47
@AndreMouche
fix test
a6d7c30 
Signed-off-by: AndreMouche <[email protected]>
@AndreMouche AndreMouche changed the title [WIP] fix inconsistent store pointers between the region-cache and store-cache fix inconsistent store pointers between the region-cache and store-cache Dec 18, 2025
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent store pointers between the region-cache and store-cache cause stale regions to become inaccessible.

1 participant

@AndreMouche