Conversation
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
If the stats are always collected in C/C++ code, then there seems to be no benefits to make it an optional feature. |
If so, |
You can depend on GRPCIO_SYS_USE_PKG_CONFIG to decide whether implement the feature. By the way, there should be also standard way to expose metrics like open census and |
Do you mean functions in stats become no-op when
open census and channelz are included in |
Maybe you should use a feature name open census and channelz should be the standard ways as they are public APIs. |
Also add some improvements Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
How about moving c changes, for example, exposing a header, to tikv/grpc instead? So that users can choose to patch grpc or just ignore unknown symbols. |
|
Not sure if this is what you mean, but please take a look. |
|
Can we merge it? |
|
I think it's ready. I am fine with the current implementation and the implementation suggested by jay in the previous comment #625 (comment). |
|
Does it help collecting metrics? grpc/grpc#35348 And you need to update your branch before getting it merged. |
Collect gRPC core metrics:
Details: https://github.com/grpc/grpc/blob/v1.56.0/src/core/lib/debug/stats_data.yaml
This PR add a new cc file called
grpc_wrap_stats.ccand generates bindingsinto a new file called
binding_stats.rs.Collecting metrics needs to include headers under in
grpc/src/.I think it's better to be an optional feature and codes are in separated files.