Add support for framehop as unwinder #267
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @Maaarcocr! It looks like this is your first PR to tikv/pprof-rs 🎉 |
Maaarcocr
force-pushed
the
master
branch
2 times, most recently
from
92c9b0d to
0557997
Compare
|
I've pushed a new commit that separates the perfmap implementation from the framehop unwinder, as they are different concerns. I hope this is better, we can now have perfmaps resolution even with the other unwinder if we want to. This also reduces the changes that were needed to make this work. |
Maaarcocr
force-pushed
the
master
branch
2 times, most recently
from
1cc6810 to
e3e2cc9
Compare
perfmaps are reloaded on demand in a bg thread Signed-off-by: Marco Concetto Rudilosso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a new unwinder based on framehop, as it was suggested in #152 and some of the code here is inspired by https://github.com/sticnarf/runwind
While doing so, I made it such that any unwinder also supports resolving symbols from
perfmapsa commonly used format by JIT compilers.I've also made it possible to configure the maximum length of each stacktrace, as for my own usecases (profiling ruby applications from a native POV) 128 was too small.
In order to make framehop works I had to:
this changes have been tested on macos on ARM and linux on x86.