feat: implement Report::from_pprof() for protobuf roundtrip conversion#279
Open
Benjscho wants to merge 1 commit intotikv:masterfrom
Open
feat: implement Report::from_pprof() for protobuf roundtrip conversion#279Benjscho wants to merge 1 commit intotikv:masterfrom
Benjscho wants to merge 1 commit intotikv:masterfrom
Conversation
|
Welcome @Benjscho! It looks like this is your first PR to tikv/pprof-rs 🎉 |
Add backwards conversion from protobuf Profile to Report, enabling roundtrip conversion between the two formats. This allows users to reconstruct Report objects from previously exported protobuf data, which is helpful for making flamegraphs. Changes: - Add Report::from_pprof() method to convert protobuf Profile back to Report - Fix pprof() method to create one location per frame instead of per symbol - Group inlined functions correctly within locations per pprof spec - Add roundtrip conversion test The changes make the protobuf output more standards-compliant by grouping inlined function symbols within the same location, which aligns with how Google's pprof tool expects the data to be structured. Signed-off-by: Ben Schofield <me@benjscho.dev>
Author
|
@YangKeao would you be able to review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add backwards conversion from protobuf Profile to Report, enabling roundtrip conversion between the two formats. This allows users to reconstruct Report objects from previously exported protobuf data, which is helpful for making flamegraphs.
Changes:
The changes make the protobuf output more standards-compliant by grouping inlined function symbols within the same location, which aligns with how Google's pprof tool expects the data to be structured.