Skip to content

new new settings (idk what to call it tbh) #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Eknous-P wants to merge 83 commits into
base: master
Choose a base branch
from
Open

new new settings (idk what to call it tbh) #2242

Eknous-P wants to merge 83 commits into from

Conversation

@Eknous-P
Copy link
Collaborator

@Eknous-P Eknous-P commented Nov 16, 2024 •
edited
Loading

todo:

  • fix keybind setting labels being NULL
  • finish keyboard section
  • maybe reorganize settings
  • maybe make macros for common setting types (checkboxes, combos, sliders...)

known issue(s):

Eknous-P and others added 30 commits October 8, 2024 18:36
@Eknous-P
le new settings code
40a4c9d
@Eknous-P
redo with abstract classes
64fbdc2
@Eknous-P
settings: more types, cleanup
4d77ecc
@Eknous-P
prepare combo
0054a87
@Eknous-P
dropdown(combo) and radio settings
d92ab32
@Eknous-P
Merge branch 'tildearrow:master' into settings3
9f97b46
@Eknous-P
settings searching
35dfdc1
@Eknous-P
t h e r e i s n o t h i n g y o u c a n d o
1ba0ffb
@Eknous-P
remove useless func, array->stdvector, cleanup
9a8b92c
@Eknous-P
remove id (use const char ptr instead), redo window cat
c7d33f4
@Eknous-P
more settings
31cda97
@Eknous-P
Merge branch 'tildearrow:master' into settings3
a7b37a2
@Eknous-P
better search results, items in child
9090d43
@Eknous-P
init active category, bullet text for search
9f1cfd8
@Eknous-P
dummy text dummy
a13d715 
fixme: va_list of references
@Eknous-P
a
4aa3a21
@Eknous-P
how did this happen
d265055
@Eknous-P
Merge branch 'tildearrow:master' into settings3
9e0e6d0
@Eknous-P
drop "def" from setting items
20cb4c5
@Eknous-P
prototype dropdowns with lambdas
5742503
@Eknous-P
proper destructior(s), moar setting
7ec4a0e
@Eknous-P
Merge branch 'tildearrow:master' into settings3
6dcbf9a
@Eknous-P
dropdown text setting, how did i
f48b501
@Eknous-P
turn dummytext to whteverdummy
d12ab23
@Eknous-P
remove redundant stuff
26e5385
@Eknous-P
vertical settings window
95e153c
@Eknous-P
settingunion
45cad85 
setting union
@Eknous-P
deconstructor
013498e
@Eknous-P
setting union conditional displayability
fa046fa
@Eknous-P
better union filterpass?
ce78cf4
@Eknous-P Eknous-P marked this pull request as ready for review November 18, 2024 19:50
Eknous-P and others added 25 commits November 19, 2024 01:10
@Eknous-P
fix and improve search
8fc6c28 
and the cursed...
@Eknous-P
settings: move setup to separate file, brief search explanation
99c2a9c
@Eknous-P
go self
7e5387e
@Eknous-P
settings: fix crash on search, separator in vertical mode
ccbeb2e
@Eknous-P
settings: fix search crash, again...
2e7a1cb
@Eknous-P
settings: double indent when treenode collapsed but search make it ex…
a466380 
…pand aaaaaa
@Eknous-P
how did i leave the
3ba94e4 
empty function...
@Eknous-P
Merge branch 'tildearrow:master' into settings3butnotreally
60cd95e
@Eknous-P
Merge branch 'settings3butnotreally' into settings3-resolve
4383d62
@Eknous-P
finish merge
42bf231
@Eknous-P
Merge pull request #16 from Eknous-P/settings3-resolve
d299608 
merge master to settings
@Eknous-P
Merge branch 'settings3butnotreally' into settings-resolve
0faa66c
@Eknous-P
asset drag&drop option
f042860
@Eknous-P
Merge pull request #17 from Eknous-P/settings-resolve
06b1ef4 
settings conflict resolve
@Eknous-P
setting changed on font path change
a973cc4
@Eknous-P
fix l10n stuff
5d1b22a
@Eknous-P
Merge branch 'settings3butnotreally' into settings-resolve
2b803b3
@Eknous-P
finish merge
15f40b3
@Eknous-P
Merge pull request #18 from Eknous-P/settings-resolve
228d13c 
merge master to settings 3?
@Eknous-P
fix backup table expading
edb4cca 
and settings_changed on note type change
@Eknous-P
Merge branch 'settings3butnotreally' into settings3-resolve
e4b1075
@Eknous-P
merge: remove duplicate struct and removed settings
2d816e5
@Eknous-P
merge: reapply note sort fix
4d468e5
@Eknous-P
Merge pull request #19 from Eknous-P/settings3-resolve
cfeccf6 
merge master to settings
@Eknous-P
do not expand categories when name not found by search in children
1107341
@freq-mod
Copy link
Collaborator

freq-mod commented Jun 8, 2025

Is this still being worked on, or should I close it?

@tildearrow
Copy link
Owner

tildearrow commented Jun 8, 2025 •
edited
Loading

It will be finished and merged for 0.7, perhaps after some ROM export work.

@Eknous-P
merge master
300949c 
TODO: apply setting changes
@tildearrow tildearrow self-assigned this Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tildearrow tildearrow

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Eknous-P @freq-mod @tildearrow