Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,17 @@

module.exports = {
root: true,
parser: 'babel-eslint',
parser: '@babel/eslint-parser',
parserOptions: {
ecmaVersion: 2018,
sourceType: 'module',
requireConfigFile: false,
ecmaFeatures: {
legacyDecorators: true,
},
},
plugins: ['ember'],
extends: [
'eslint:recommended',
'plugin:ember/recommended',
'plugin:prettier/recommended',
],
extends: ['eslint:recommended', 'plugin:ember/recommended'],
env: {
browser: true,
},
Expand Down
12 changes: 6 additions & 6 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
version: 2
updates:
- package-ecosystem: npm
directory: '/'
directory: "/"
schedule:
interval: weekly
time: '13:00'
time: "13:00"
open-pull-requests-limit: 10
- package-ecosystem: 'github-actions'
directory: '/'
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: 'weekly'
time: '13:00'
interval: "weekly"
time: "13:00"
9 changes: 6 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,14 @@ jobs:
test:
name: "Tests"
runs-on: ubuntu-latest
timeout-minutes: 10

steps:
- uses: actions/checkout@v3
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 16.x
cache: yarn
- name: Install Dependencies
run: yarn install --frozen-lockfile
Expand All @@ -33,12 +34,13 @@ jobs:
floating:
name: "Floating Dependencies"
runs-on: ubuntu-latest
timeout-minutes: 10

steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 16.x
cache: yarn
- name: Install Dependencies
run: yarn install --no-lockfile
Expand All @@ -49,6 +51,7 @@ jobs:
name: ${{ matrix.try-scenario }}
runs-on: ubuntu-latest
needs: "test"
timeout-minutes: 10

strategy:
fail-fast: false
Expand All @@ -66,7 +69,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 16.x
cache: yarn
- name: Install Dependencies
run: yarn install --frozen-lockfile
Expand Down
1 change: 0 additions & 1 deletion .glintrc.yml

This file was deleted.

1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# compiled output
/dist/
/tmp/
/tests/dummy/config/ember-cli-update.json

# dependencies
/bower_components/
Expand Down
15 changes: 15 additions & 0 deletions .prettierrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,19 @@

module.exports = {
singleQuote: true,
htmlWhitespaceSensitivity: 'css',
overrides: [
{
files: ['*.hbs'],
options: {
singleQuote: false,
},
},
{
files: ['*.yml'],
options: {
singleQuote: false,
},
},
],
};
20 changes: 10 additions & 10 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,24 @@

## Installation

* `git clone <repository-url>`
* `cd ember-positioner`
* `yarn install`
- `git clone <repository-url>`
- `cd ember-positioner`
- `yarn install`

## Linting

* `yarn lint`
* `yarn lint:fix`
- `yarn lint`
- `yarn lint:fix`

## Running tests

* `ember test` – Runs the test suite on the current Ember version
* `ember test --server` – Runs the test suite in "watch mode"
* `ember try:each` – Runs the test suite against multiple Ember versions
- `ember test` – Runs the test suite on the current Ember version
- `ember test --server` – Runs the test suite in "watch mode"
- `ember try:each` – Runs the test suite against multiple Ember versions

## Running the dummy application

* `ember serve`
* Visit the dummy application at [http://localhost:4200](http://localhost:4200).
- `ember serve`
- Visit the dummy application at [http://localhost:4200](http://localhost:4200).

For more information on using ember-cli, visit [https://cli.emberjs.com/release/](https://cli.emberjs.com/release/).
11 changes: 3 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,31 +13,26 @@

[Short description of the addon.]


## Compatibility

* Ember.js v3.25 or above
* Ember CLI v3.25 or above
* Node.js v12 or above

- Ember.js v3.25 or above
- Ember CLI v3.25 or above
- Node.js v12 or above

## Installation

```
ember install ember-positioner
```


## Usage

[Longer description of how to use the addon in apps.]


## Contributing

See the [Contributing](CONTRIBUTING.md) guide for details.


## License

This project is licensed under the [MIT License](LICENSE.md).
4 changes: 2 additions & 2 deletions addon/components/positioner/content.hbs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div
class="positioner {{if @isHidden "pointer-events-none"}}"
class="positioner {{if @isHidden 'pointer-events-none'}}"
aria-hidden={{if @isHidden "true" "false"}}
...attributes
>
Expand All @@ -11,4 +11,4 @@
{{yield}}
</div>
</div>
</div>
</div>
6 changes: 3 additions & 3 deletions addon/components/positioner/index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
{{yield this to="content"}}
</Positioner::Content>
{{else}}
{{!-- TODO: https://github.com/tildeio/events-app/issues/521
{{! TODO: https://github.com/tildeio/events-app/issues/521
We can eliminate the redundant if/else construction here by using
the maybe-in-element addon, but it has no types yet, so it causes
Glint errors. --}}
Glint errors. }}
{{#in-element this.altContainer insertBefore=null}}
<Positioner::Content
@isHidden={{this.isHidden}}
Expand All @@ -26,4 +26,4 @@
</Positioner::Content>
{{/in-element}}
{{/if}}
{{/unless}}
{{/unless}}
2 changes: 1 addition & 1 deletion addon/components/title/index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@
{{! If not enabled, just show the anchor content without the tooltip functionality }}
{{yield}}
{{/if}}
</div>
</div>
77 changes: 39 additions & 38 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
"lint:hbs:fix": "ember-template-lint . --fix",
"lint:js": "eslint . --cache",
"lint:js:fix": "eslint . --fix",
"lint:prettier": "prettier --check .",
"lint:prettier:fix": "prettier --write .",
"lint:glint": "glint",
"start": "ember serve",
"test": "npm-run-all lint test:ember",
Expand All @@ -29,85 +31,84 @@
"postpack": "ember ts:clean"
},
"dependencies": {
"@ember/render-modifiers": "^2.0.0",
"@ember/render-modifiers": "^2.0.4",
"@glimmer/component": "^1.1.2",
"@glimmer/tracking": "^1.1.2",
"@popperjs/core": "^2.9.2",
"ember-auto-import": "^2.4.1",
"@popperjs/core": "^2.11.5",
"ember-auto-import": "^2.4.2",
"ember-cli-babel": "^7.26.11",
"ember-cli-htmlbars": "^6.0.1",
"ember-cli-typescript": "^5.0.0",
"ember-concurrency": "^2.1.0",
"ember-cli-htmlbars": "^6.1.0",
"ember-cli-typescript": "^5.1.0",
"ember-concurrency": "^2.2.1",
"ember-concurrency-async": "^1.0.0",
"ember-concurrency-ts": "^0.3.1",
"ember-modifier": "^3.0.0",
"ember-modifier": "^3.2.7",
"ember-on-helper": "^0.1.0"
},
"devDependencies": {
"@babel/core": "^7.18.9",
"@babel/eslint-parser": "^7.18.9",
"@ember/optional-features": "^2.0.0",
"@ember/test-helpers": "^2.7.0",
"@embroider/test-setup": "^1.6.0",
"@gavant/glint-template-types": "^0.1.0",
"@glint/core": "^0.8.0",
"@glint/environment-ember-loose": "^0.8.0",
"@ember/test-helpers": "^2.8.1",
"@embroider/test-setup": "^1.8.3",
"@gavant/glint-template-types": "^0.1.5",
"@glint/core": "^0.9.1",
"@glint/environment-ember-loose": "^0.9.1",
"@types/ember-qunit": "^5.0.0",
"@types/ember-resolver": "^5.0.10",
"@types/ember-resolver": "^5.0.11",
"@types/ember__application": "^4.0.0",
"@types/ember__array": "^4.0.0",
"@types/ember__component": "^4.0.0",
"@types/ember__array": "^4.0.1",
"@types/ember__component": "^4.0.8",
"@types/ember__controller": "^4.0.0",
"@types/ember__debug": "^4.0.0",
"@types/ember__debug": "^4.0.1",
"@types/ember__engine": "^4.0.0",
"@types/ember__error": "^4.0.0",
"@types/ember__object": "^4.0.0",
"@types/ember__object": "^4.0.2",
"@types/ember__polyfills": "^4.0.0",
"@types/ember__routing": "^4.0.0",
"@types/ember__runloop": "^4.0.0",
"@types/ember__routing": "^4.0.7",
"@types/ember__runloop": "^4.0.1",
"@types/ember__service": "^4.0.0",
"@types/ember__template": "^4.0.0",
"@types/ember__test": "^4.0.0",
"@types/ember__test-helpers": "^2.0.1",
"@types/ember__test-helpers": "^2.8.0",
"@types/ember__utils": "^4.0.0",
"@types/htmlbars-inline-precompile": "^3.0.0",
"@types/qunit": "^2.11.2",
"@types/qunit": "^2.19.2",
"@types/rsvp": "^4.0.4",
"@typescript-eslint/eslint-plugin": "^4.28.3",
"@typescript-eslint/parser": "^4.29.0",
"babel-eslint": "^10.1.0",
"@typescript-eslint/eslint-plugin": "^5.30.7",
"@typescript-eslint/parser": "^5.30.7",
"broccoli-asset-rev": "^3.0.0",
"ember-cli": "~4.4.0",
"ember-cli": "~4.5.0",
"ember-cli-dependency-checker": "^3.3.1",
"ember-cli-inject-live-reload": "^2.1.0",
"ember-cli-sri": "^2.1.1",
"ember-cli-terser": "^4.0.2",
"ember-cli-typescript-blueprints": "^3.0.0",
"ember-disable-prototype-extensions": "^1.1.3",
"ember-export-application-global": "^2.0.1",
"ember-load-initializers": "^2.1.2",
"ember-page-title": "^7.0.0",
"ember-qunit": "^5.1.5",
"ember-resolver": "^8.0.3",
"ember-source": "~4.5.0",
"ember-source-channel-url": "^3.0.0",
"ember-template-lint": "^4.8.0",
"ember-template-lint": "^4.10.1",
"ember-try": "^2.0.0",
"eslint": "^7.32.0",
"eslint": "^8.20.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-ember": "^10.6.1",
"eslint-plugin-ember": "^11.0.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-prettier": "^4.0.0",
"eslint-plugin-qunit": "^7.2.0",
"eslint-plugin-qunit": "^7.3.1",
"loader.js": "^4.7.0",
"npm-run-all": "^4.1.5",
"prettier": "^2.6.2",
"prettier": "^2.7.1",
"qunit": "^2.19.1",
"qunit-dom": "^2.0.0",
"typescript": "^4.6.0",
"webpack": "^5.72.1"
"typescript": "^4.7.4",
"webpack": "^5.73.0"
},
"peerDependencies": {
"@gavant/glint-template-types": "^0.1.0",
"@glint/environment-ember-loose": "^0.8.0"
"@gavant/glint-template-types": "^0.1.5",
"@glint/environment-ember-loose": "^0.9.1"
},
"engines": {
"node": "12.* || 14.* || >= 16"
Expand All @@ -119,7 +120,7 @@
"configPath": "tests/dummy/config"
},
"volta": {
"node": "12.22.7",
"yarn": "1.22.17"
"node": "16.16.0",
"yarn": "1.22.19"
}
}
10 changes: 5 additions & 5 deletions tests/dummy/app/index.html
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<meta charset="utf-8" />
<title>Dummy</title>
<meta name="description" content="">
<meta name="viewport" content="width=device-width, initial-scale=1">
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />

{{content-for "head"}}

<link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css">
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/dummy.css">
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css" />
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/dummy.css" />

{{content-for "head-footer"}}
</head>
Expand Down
Loading