This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Use the standard convention for function pointers in libcruby #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically you never take
extern "C" fn
directly, as there is no way topass
NULL
there without using transmute. Bindgen and most other toolsgenerally use
Option
for this purpose.I've also changed the alloc and free functions to use the functions
provided on box for converting to/from pointers, rather than relying on
its internal representation. There's still the
transmute
on the class,but I'm not entirely sure what that's doing so I've left it alone for
now.