Skip to content
This repository was archived by the owner on Apr 4, 2019. It is now read-only.

[WIP] Globals + canary bower artifact repo deployment #300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jayphelps
Copy link
Contributor

Update 05/06/15: Wow, things have changed a TON with Glimmer...Still not settled down enough to finish this...yet.

I can haz a bower dist? How bout globals?

I'll need someone to help get this past the finish line. @rwjblue put me in the right direction but the global dist fails to load with Uncaught Error: Could not find module htmlbars-util/handlebars/safe-string (others inside htmlbars-util also will fail to find more htmlbars-util/handlebars/*).

Digging through, I expect it has something to do with #194. Does amd/htmlbars.amd.js even work right now as-is? Doesn't for me.

  • Sit on my butt until [WIP] Reactive rerendering #282 is merged.
  • Fix htmlbars-util/handlebars inline dependency issue
  • What about htmlbars-runtime??? (should it get merged into the window.HTMLBars namespace?)
  • Someone create tildeio/htmlbars-builds or equivalent artifact storage. (bower sucks needs this)

AFAIK I can't truly pre-test all the travis -> artifact push stuff, but it's mostly copy-pasta from ember-qunit, et al.

@jayphelps jayphelps force-pushed the bower-dist branch 2 times, most recently from 193c157 to 84f76c6 Compare February 18, 2015 00:07
});
trees.push(movedCjsTests);

console.log('>>>' ,packageName);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional console log?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOH

@mixonic
Copy link
Collaborator

mixonic commented Feb 18, 2015

@jayphelps the runtime package would possibly used if you wanted to consume HTMLBars as a stand-alone templating engine. In Ember, we provide our own hooks implementation to HTMLBars and thus in many ways the hooks are only used for testing and proof-of-concept. @mmun might be able to say if that would change with the new reactive rendering changes. I know the concept of hooks will change.

I'm unsure if we're stable enough to have a great story here yet, but I would love to see HTMLBars a library used for things beyond Ember.

@jayphelps
Copy link
Contributor Author

@mixonic I definitely need htmlbars-runtime myself. One of the above tasks mentions I wasn't sure where it would live, globals-wise.

@mixonic
Copy link
Collaborator

mixonic commented Feb 18, 2015

@jayphelps for sure, I'm open to exposing it in an AMD and globals public API. HTMLBars.Runtime.hooks seems ok. But as I hope I made clear: I am uncertain of if hooks will even survive some of the changes @wycats and @tomdale are working on.

@jayphelps
Copy link
Contributor Author

@mixonic Yup, got it. We will adapt; Resistance is futile.

@lazd
Copy link

lazd commented Mar 5, 2015

Definitely interested in seeing this finished 👍

@jayphelps
Copy link
Contributor Author

@lazd waiting for Glimmer changes to settle. 😀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants