Skip to content

[Feat][Platform] Add ops_manifest.yaml with rmsnorm_fwd entry#636

Draft
lcy-seso wants to merge 2 commits intotile-ai:mainfrom
lcy-seso:feat/platform/issue-627
Draft

[Feat][Platform] Add ops_manifest.yaml with rmsnorm_fwd entry#636
lcy-seso wants to merge 2 commits intotile-ai:mainfrom
lcy-seso:feat/platform/issue-627

Conversation

@lcy-seso
Copy link
Collaborator

Closes #627

Summary

  • Create ops_manifest.yaml at repo root as the spec-driven op registry, establishing the schema for all future op definitions.
  • Register rmsnorm_fwd as the first entry with all four required fields: signature, workloads, roofline, and source.
  • Workloads cover Llama-3.1-8B (hidden=4096), 70B (hidden=8192), and 405B (hidden=16384) with both prefill (seq_len=2048) and decode (seq_len=1) shapes.
  • Add validation test suite (tests/test_ops_manifest.py) with 16 tests covering schema structure, field presence, source path existence, and workload completeness.

Test plan

  • python -m pytest tests/test_ops_manifest.py -- 16/16 pass
  • All source file paths in manifest resolve to existing files
  • YAML is valid and parseable
  • Workload dimensions match Llama-3.1 model specs

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

@github-actions github-actions bot added the feature New feature or new operator label Mar 23, 2026
@lcy-seso lcy-seso added the all-ai-powered Produced entirely by automated contributors label Mar 23, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes a foundational mechanism for defining and managing operations within the TileOPs framework by introducing ops_manifest.yaml. This new YAML file serves as a spec-driven registry, standardizing how operations are described, including their signatures, performance models, and associated source files. The initial entry for rmsnorm_fwd demonstrates this new structure, complete with detailed workloads derived from Llama-3.1 models. Accompanying this, a robust test suite ensures the integrity and correctness of the manifest's structure and content, paving the way for consistent op definitions.

Highlights

  • New Op Registry: Introduced ops_manifest.yaml at the repository root to serve as a spec-driven op registry, establishing a standardized schema for defining operations within the TileOPs framework.
  • RMSNorm Forward Entry: Registered rmsnorm_fwd as the first operation in the manifest, complete with its signature, workloads, roofline model, and source file paths.
  • Llama-3.1 Workloads: Included comprehensive workloads for rmsnorm_fwd covering Llama-3.1-8B, 70B, and 405B models, with both prefill (seq_len=2048) and decode (seq_len=1) shapes.
  • Validation Test Suite: Added a new validation test suite (tests/test_ops_manifest.py) with 16 tests to ensure the manifest's schema, field presence, source path existence, and workload completeness.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@lcy-seso
Copy link
Collaborator Author

/gemini review

@lcy-seso lcy-seso requested a review from Copilot March 23, 2026 12:42
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a well-structured ops_manifest.yaml for spec-driven op registration and includes a comprehensive test suite. The implementation is solid. My feedback focuses on improving the accuracy of the roofline model, enhancing readability in the manifest, and adhering to Python style conventions in the test file. These adjustments will increase the correctness and maintainability of the new components.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new ops_manifest.yaml file to serve as a centralized, spec-driven registry for operations, starting with rmsnorm_fwd. It also adds a comprehensive test suite to validate the manifest's structure and content. The changes are well-structured and the tests are thorough. I have a few suggestions to improve the accuracy of the roofline model in the manifest and to align the test code with standard Python style conventions.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a spec-driven operator registry to the repo and validates it via a new test suite, using rmsnorm_fwd as the first registered op.

Changes:

  • Introduce a root-level ops_manifest.yaml defining the initial manifest schema and registering rmsnorm_fwd.
  • Add tests/test_ops_manifest.py to validate manifest structure, required fields, source-path existence, and workload coverage.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
ops_manifest.yaml Adds the initial ops manifest schema and rmsnorm_fwd entry (signature/workloads/roofline/source).
tests/test_ops_manifest.py Adds pytest validation for manifest schema, required fields, source paths, and workload completeness.

@lcy-seso lcy-seso force-pushed the feat/platform/issue-627 branch from 817a051 to 8082ede Compare March 23, 2026 13:13
lcy-seso and others added 2 commits March 24, 2026 15:34
Create spec-driven op registry at repo root with rmsnorm_fwd as
the first entry. Includes signature, workloads (Llama-3.1 8B/70B/405B
prefill+decode), roofline cost model, and source paths. Adds
validation test suite and pyyaml dev dependency.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@lcy-seso lcy-seso force-pushed the feat/platform/issue-627 branch from 7db2cc9 to 744edc0 Compare March 24, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

all-ai-powered Produced entirely by automated contributors feature New feature or new operator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat][Platform] Create ops_manifest.yaml with rmsnorm_fwd as first entry

2 participants