Skip to content

OTA updater regression + pkg fixes#104

Merged
madclaws merged 1 commit intomainfrom
build/pkg-ui-fix
Mar 17, 2026
Merged

OTA updater regression + pkg fixes#104
madclaws merged 1 commit intomainfrom
build/pkg-ui-fix

Conversation

@madclaws
Copy link
Copy Markdown
Member

  • OTA updater was failing due to path permission issue, fixed it by running the sh command with sudo

  • UI enhancements in pkg installer

- OTA updater was failing due to path permission issue,
fixed it by running the sh command with sudo

- UI enhancements in pkg installer
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 17, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 86f5597a-d161-4b62-a27a-7a8e150eb52a

📥 Commits

Reviewing files that changed from the base of the PR and between 451390c and f5b1420.

📒 Files selected for processing (6)
  • pkg/build_full.sh
  • pkg/distribution.xml
  • pkg/distribution_network.xml
  • pkg/resources/welcome.html
  • pkg/resources/welcome_network.html
  • tiles/src/utils/installer.rs

📝 Walkthrough

Walkthrough

The changes enable macOS notarization in the package build process by uncommenting the notarytool submission and stapler commands in the build script. Installer UI text is updated by removing heading elements from welcome pages and renaming distribution variants from "Tiles" to "Tiles Offline" and "Tiles Network". The installer invocation logic is modified to use elevated privileges via sudo with status-based branching that returns distinct success or failure messages based on the command exit status.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • OTA updater #89: Directly related as it introduces the original installer updater functionality that these changes now enhance with sudo elevation and improved status handling.
✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch build/pkg-ui-fix
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

@madclaws madclaws merged commit 01f4f89 into main Mar 17, 2026
1 of 2 checks passed
@madclaws madclaws deleted the build/pkg-ui-fix branch March 17, 2026 01:02
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tiles/src/utils/installer.rs 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant