Bump go-safecast to v2.0.0 closes #23

[jas4711]

As used by Debian packaging - should be ready for merge, see review below

[jas4711]

The b078fe3 commit was uploaded to Debian experimental, so we get things to build in Debian with go-safecast v2. I'm not sure how to test the patch, I'll get to updating binaries eventually, and maybe find my tkey somewhere for testing...

[jas4711]

@ccoVeille could you review if this makes sense from a go-safecast API point of view?

[ccoVeille]

You have an issue here, it should be something like this

Suggested change

	github.com/ccoveille/go-safecast v2.0.0
	github.com/ccoveille/go-safecast/v2 v2.0.0

So to make sure everything is fine:

• remove the line here
• run go mod tidy
• run go get -u github.com/ccoveille/go-safecast/v2
• run go mod tidy
• commit again

[jas4711]

Thank you! Better now?

Debian build system doesn't look at go.mod, so verifying if things works or not was a bit hard for me.

[ccoVeille]

Let's wait for someone to start the CI to know if it's OK. But otherwise LGTM 👍

[jas4711]

Thanks for review @ccoVeille - just to confirm, does the actual API changes looks correct to you? Getting int conversion wrong here may be have rather bad consequences for this code, so the more eyes can check it the better. I'll see if I somehow can confirm using a real physical Tillitis key that applications linked to this library still works properly.

[ccoVeille]

I had also reviewed the changes you did, no worries.

I can affirm the ToUintX replaced by Convert [uintX] are all OK.

And than the code behind v1 and v2 is identical and fully tested in my package. I only changed the methods to use.

So the changes are safe in term of code, but of course a full test made by someone with a key would be better.

[jas4711]

Splendid, thank you! Over to upstream...

[dehanj]

Looks good, tested with real hardware.

Thanks for the help migrating, appreciate it!