Skip to content

tests/Makefile: properly use cornersync mode from Makefile variable #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

tests/Makefile: properly use cornersync mode from Makefile variable #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ EXTRACT_FILES := $(ATTACK_IMAGES:attack/%=extract/%.json)
extract/%.json: attack/%
$(QECHO) GET $@
$Q mkdir -p $(dir $@)
$Q $(SRCDIR)/imagewmark get $(__TESTKEY) --expect $(WATERMARK) $< --json > [email protected]
$Q $(SRCDIR)/imagewmark get $(__TESTKEY) --expect $(WATERMARK) --cornersync $(CORNERSYNC_MODE) $< --json > [email protected]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While adding --cornersync $(CORNERSYNC_MODE) here is correct, the same flag is missing from the fallback imagewmark get call on line 128. This leads to inconsistent behavior, as the CORNERSYNC_MODE will not be respected if the initial extraction fails. For consistent behavior, please also add --cornersync $(CORNERSYNC_MODE) to the command on line 128.

$Q $(WITHOUT_ORIGINAL) || grep -qw "$(WATERMARK)" [email protected] || { \
echo ' ALIGNED ' $@ \
&& $(SRCDIR)/imagewmark get $(__TESTKEY) --expect $(WATERMARK) $< --json \
Expand Down