Change TS return types from PromiseLike to Promise #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`start()` and `promise()` return a real Promise, which has `then` and `catch`. According to the TS docs (link below), `PromiseLike` only has `then` but not `catch`, so it's helpful to give the extra information here about the return type, so people know they can use `catch` on the result as well. https://github.com/Microsoft/TypeScript/blob/696b0f8d43524f743048a6c5d5944939e8b43b99/lib/lib.es5.d.ts#L1291-L1319
|
❌ Build es6-promise-pool 194 failed (commit e6e814ab08 by @james-rabbit) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start()andpromise()return a real Promise, which hasthenandcatch.According to the TS docs,
PromiseLikeonly hasthenbut notcatch, so it's helpful to give the extra information here about the return type, so people know they can usecatchon the result as well.