Sync json transport protocol with proton. #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yibo-Chen13
force-pushed
the
enhance/50-go-driver-should-support-type-json
branch
15 times, most recently
from
c0e2b34 to
08c522f
Compare
| @@ -71,10 +71,11 @@ func TestJson(t *testing.T) { | |||
| resultMap map[string]interface{} | |||
| resultStr string | |||
| ) | |||
| if err := conn.QueryRow(ctx, "SELECT (* except _tp_time) FROM test_json WHERE _tp_time > earliest_ts() LIMIT 1").Scan(&resultMap); assert.NoError(t, err) { | |||
| time.Sleep(3 * time.Second) | |||
There was a problem hiding this comment.
Looks previous select from stream with "WHERE _tp_time > earliest_ts() LIMIT 1" is a little better as no need to write additional time.Sleep
There was a problem hiding this comment.
But if without sleep ,the select result become "{\"_dummy\": 0}".I think it is due to SerializationObject will check if the column is finalized.If there is no exact json data,a default null value "{\"_dummy\": 0}" will be seted.
Maybe due to network or scheduling reasons, the json column has not been fully inserted successfully at the time of the select query,so we get the result "{\"_dummy\": 0}".But I'm not sure, maybe I need some time to find out why.
Yibo-Chen13
force-pushed
the
enhance/50-go-driver-should-support-type-json
branch
from
08c522f to
7b55be8
Compare
yuzifeng1984
approved these changes
Nov 26, 2024
Yibo-Chen13
deleted the
enhance/50-go-driver-should-support-type-json
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.