update streaming-query example #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yibo-Chen13
force-pushed
the
example/issue-48-update-streaming-query-examples
branch
2 times, most recently
from
e053289 to
ad56d24
Compare
Yibo-Chen13
force-pushed
the
example/issue-48-update-streaming-query-examples
branch
from
ad56d24 to
73f4981
Compare
yuzifeng1984
reviewed
Jan 6, 2025
yuzifeng1984
reviewed
Jan 6, 2025
| } | ||
| defer rows.Close() | ||
| go func() { | ||
| time.Sleep(time.Duration(20) * time.Second) |
There was a problem hiding this comment.
we can capture signal to graceful shutdown program instead of running for 20 seconds.
please refer documents such as
https://emretanriverdi.medium.com/graceful-shutdown-in-go-c106fe1a99d9
There was a problem hiding this comment.
I would start reader and writers as go routines. The main thread will wait and cancel them via context once received signal.
https://gobyexample.com/timeouts
https://gobyexample.com/waitgroups
https://gobyexample.com/signals
yuzifeng1984
reviewed
Jan 6, 2025
| } | ||
| } | ||
|
|
||
| func main() { |
There was a problem hiding this comment.
I got below error in running the code. can you double check?
yuzifeng1984
reviewed
Jan 6, 2025
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| for id := int64(0); id < int64(7); id++ { |
There was a problem hiding this comment.
let's make 7 a const variable such as NumOfWriters to make code more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.