refactor(datastream): defer pipe rotation until next batch write #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add rotatePending flag to defer pipe rotation until next row write in CSV, JSON, JSONLines, and Parquet readers - Implement pre-write rotation check to close current pipe before writing to new one - Add pipeOpen state tracking to prevent double-closing pipes across all reader channels - Replace immediate pipe rotation with deferred rotation pattern for cleaner state management - Update CSV reader to mark rotation pending instead of executing immediately - Update JSON reader to rotate pipe at start of next batch iteration - Update JSONLines reader to rotate pipe at start of next batch iteration - Update Parquet Arrow reader to defer rotation and track pipe state - Update Parquet reader to defer rotation and track pipe state - Improve error handling by ensuring pipes are only closed when open - Clarify comments from "close the prior reader?" to "close the prior reader"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #60