Skip to content

docs: update for name and destination changes #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Askir
Copy link
Contributor

@Askir Askir commented Apr 23, 2025

No description provided.

@Askir Askir temporarily deployed to internal-contributors April 23, 2025 12:51 — with GitHub Actions Inactive
@Askir Askir changed the base branch from released to main April 23, 2025 12:51
@Askir Askir force-pushed the jascha/update-docs-name-dest branch 2 times, most recently from 8840d21 to 2930189 Compare April 23, 2025 14:49
@Askir Askir changed the title Jascha/update docs name dest docs: update for name and destination changes Apr 23, 2025
@Askir Askir marked this pull request as ready for review April 23, 2025 14:54
@Askir Askir requested a review from a team as a code owner April 23, 2025 14:54
@Askir Askir force-pushed the jascha/update-docs-name-dest branch from 4b33663 to 5949c2f Compare April 24, 2025 09:23
fix: destination_table( not just destination(

Update docs/vectorizer/api-reference.md

Co-authored-by: Matvey Arye <[email protected]>
Signed-off-by: Jascha Beste <[email protected]>

Update docs/vectorizer/api-reference.md

Co-authored-by: Matvey Arye <[email protected]>
Signed-off-by: Jascha Beste <[email protected]>

docs: fix some typos and more precise language
@Askir Askir force-pushed the jascha/update-docs-name-dest branch from 5949c2f to 88818ed Compare April 24, 2025 09:24
@Askir Askir requested review from cevian and smoya April 25, 2025 11:09
Copy link
Collaborator

@cevian cevian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits but approving

SELECT ai.disable_vectorizer_schedule(1);

-- Using name (recommended)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: make the recommended example come first

SELECT ai.drop_vectorizer(1);
```

- Remove the vectorizer with ID 1 and drop the target table and view as well:
- Remove a vectorizer by name (recommended):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: first

-- Using ID
SELECT ai.vectorizer_queue_pending(1);

-- Using name (recommended)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants