feat!: rename to -dangerously-enable-client-side-sorting #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesGuthrie
force-pushed
the
jg/dangerous-client-side-sorting
branch
from
fa0f909 to
89199e7
Compare
The name 'enable-client-side-sorting' gives one the sense that it could be innocuous to enable. It maps directly to the enable_direct_compress_copy_client_sorted TimescaleDB GUC, which allows clients to guarantee that all data is in sorted order and that there are no overlapping ranges of data in different compressed batches. Due to the nature of timescaledb-parallel-copy, this is only safe to use when the following restrictions apply to the data to be inserted: - It does not overlap (in the time dimension) with any data which is already stored in compressed form in the database. - It is in sorted order (corresponding to the compression settings on the target table, i.e. taking time dimension, segmenting and ordering configuration into account). - It is strictly monotonic in the time dimension (taking segment by settings into account). Failure to adhere to these restrictions can result in incorrect query results.
JamesGuthrie
force-pushed
the
jg/dangerous-client-side-sorting
branch
from
89199e7 to
74aad17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name 'enable-client-side-sorting' gives one the sense that it could be innocuous to enable.
It maps directly to the enable_direct_compress_copy_client_sorted TimescaleDB GUC, which allows clients to guarantee that all data is in sorted order and that there are no overlapping ranges of data in different compressed batches.
Due to the nature of timescaledb-parallel-copy, this is only safe to use when the following restrictions apply to the data to be inserted:
Failure to adhere to these restrictions can result in incorrect query results.