Skip to content

Get tsdb version from version.config if run from a tag #10023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
surister wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Get tsdb version from version.config if run from a tag #10023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/apt-packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,16 @@ jobs:

- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Get version of latest release
- name: Get expected version
id: versions
run: |
version=$(wget -q https://api.github.com/repos/timescale/timescaledb/releases/latest -O - | jq -r .tag_name)
# if run from a tag, check the repo's version, meant to be run after a release
# otherwise we rely on github's api for scheduled runs.
if [ "${{ github.ref_type }}" = "tag" ]; then

@akuzm akuzm Jun 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is supposed to check the version of packages in the package repo, right? It's expected that it fails if the version of packages is not up to date.

I think it will lead to confusion if it actually doesn't check it sometimes, depending on the run conditions.

@surister surister Jun 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is expected to fail if the repo's version does not match the latest installable version, when run from a tag, which we only do after releases.

The way I see it is that we currently miss some test surface, e.g. in the last release it didn't catch that the binaries were actually not uploaded, with this it'd have caught it.

To make it less confusing we could add logging explaining why it failed, but we need to run this test.

@surister surister Jun 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also create a different step and conditionally run it, same logic just on the github step level

version=$(grep '^version = ' version.config | sed -e 's!version = !!')
else
version=$(wget -q https://api.github.com/repos/timescale/timescaledb/releases/latest -O - | jq -r .tag_name)
fi
echo "version=${version}"
echo "version=${version}" >>$GITHUB_OUTPUT

Expand Down Expand Up @@ -128,4 +134,3 @@ jobs:
if: always()
run: |
cat /var/log/postgresql/postgresql-${{ matrix.pg }}-main.log

Loading