Skip to content

Add ddl events for chunk auto publication - #10141

Draft
thedodd wants to merge 1 commit into
mainfrom
chunk-auto-pub-hook
Draft

Add ddl events for chunk auto publication#10141
thedodd wants to merge 1 commit into
mainfrom
chunk-auto-pub-hook

Conversation

@thedodd

@thedodd thedodd commented Jun 25, 2026

Copy link
Copy Markdown
Member

When chunk auto publication is enabled, we now emit ddl events
when publications are altered for adding the new chunk.

Will rebase this work after #10128 is merged.

@thedodd
thedodd force-pushed the chunk-auto-pub-hook branch from 0646940 to a1f296e Compare June 25, 2026 14:46
@thedodd
thedodd requested a review from arajkumar June 25, 2026 14:47
@thedodd
thedodd force-pushed the chunk-auto-pub-hook branch 4 times, most recently from 992a657 to fb35b32 Compare June 25, 2026 16:32
@thedodd thedodd changed the title Add hook for when chunks are added to publications Add ddl events for chunk auto publication Jun 25, 2026
@thedodd
thedodd requested review from gayyappan and zilder June 25, 2026 16:34
@thedodd
thedodd force-pushed the chunk-auto-pub-hook branch 8 times, most recently from 69fe045 to 0fb6aae Compare June 25, 2026 21:49
@timescale timescale deleted a comment from codecov Bot Jun 25, 2026
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/chunk.c 91.66% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@thedodd
thedodd force-pushed the chunk-auto-pub-hook branch from 0fb6aae to 752e29a Compare June 26, 2026 01:31
@thedodd

thedodd commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

The codecov report is incorrectly stating that the PG_FINAlLY line is not exercised, though the body is accurately reported as being covered. NBD.

@arajkumar
arajkumar self-requested a review June 26, 2026 02:05
@thedodd
thedodd force-pushed the chunk-auto-pub-hook branch 6 times, most recently from a475823 to 61066e7 Compare June 26, 2026 20:40
@thedodd
thedodd force-pushed the chunk-auto-pub-hook branch 11 times, most recently from 1550efd to ad892e6 Compare June 29, 2026 19:50
When chunk auto publication is enabled, we now emit ddl events
when publications are altered for adding the new chunk.
@thedodd
thedodd force-pushed the chunk-auto-pub-hook branch from ad892e6 to 4c195e2 Compare June 29, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants