Fix unique constraint violation when NULLS NOT DISTINCT - #10150
Open
kpan2034 wants to merge 1 commit into
Open
Conversation
When inserting into a compressed chunk, it was possible to violate a unique constraint specifying NULLS NOT DISTINCT. `decompress_batches_scan` would incorrectly filter these rows out and skip checking constraints against rows containing NULLs. Fixes #10057.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
antekresic
reviewed
Jul 2, 2026
| -- test that this is correctly handled when using table scan | ||
| -- see https://github.com/timescale/timescaledb/issues/10057 | ||
| SELECT count(compress_chunk(c)) FROM show_chunks('nulls_not_distinct') c; | ||
| set timescaledb.enable_dml_decompression_tuple_filtering to off; |
Member
There was a problem hiding this comment.
This kinda feels weird. Could we add a test case where we drop the compressed chunk index and test that works correctly now as well? Reading the issue seems that also caused the issue.
|
This pull request has been automatically marked as stale due to lack of activity. This pull request will be closed in 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When inserting into a compressed chunk, it was possible to violate a unique constraint specifying NULLS NOT DISTINCT.
decompress_batches_scanwould incorrectly filter these rows out and skip checking constraints against rows containing NULLs.Fixes #10057.
Disable-check: force-changelog-file