Skip to content

Stabilize unit test for collation fix in PR10230 - #10239

Merged
natalya-aksman merged 1 commit into
timescale:mainfrom
natalya-aksman:stabilize_unit_test_for_collation_fix_in_10230
Jul 9, 2026
Merged

Stabilize unit test for collation fix in PR10230#10239
natalya-aksman merged 1 commit into
timescale:mainfrom
natalya-aksman:stabilize_unit_test_for_collation_fix_in_10230

Conversation

@natalya-aksman

@natalya-aksman natalya-aksman commented Jul 8, 2026

Copy link
Copy Markdown
Member

Disable-check: force-changelog-file

We need to reliably build CI configurations with ICU support before we can test ICU-provided non-deterministic collations. Until then the unit test for #10230 will be using different default collations in the equality predicate to test the fix.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

@dbeck, @melihmutlu: please review this pull request.

Powered by pull-review

@natalya-aksman
natalya-aksman requested review from Poroma-Banerjee, akuzm and dbeck and removed request for dbeck and melihmutlu July 8, 2026 17:37
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@natalya-aksman
natalya-aksman force-pushed the stabilize_unit_test_for_collation_fix_in_10230 branch from 3bc3c05 to e82cebb Compare July 9, 2026 12:13
@natalya-aksman
natalya-aksman merged commit 656740b into timescale:main Jul 9, 2026
60 checks passed
@timescale-automation

Copy link
Copy Markdown
Member

Automated backport to 2.28.x not done: cherry-pick failed.

Git status

HEAD detached at origin/2.28.x
You are currently cherry-picking commit 656740b25.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tsl/test/expected/compressed_collation.out
	both modified:   tsl/test/sql/compressed_collation.sql

no changes added to commit (use "git add" and/or "git commit -a")

Job log

@timescale-automation timescale-automation added the auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) label Jul 9, 2026
natalya-aksman added a commit that referenced this pull request Jul 9, 2026
…PR10230 (#10239) (#10244)

Disable-check: force-changelog-file

We need to reliably build CI configurations with ICU support before we
can test ICU-provided non-deterministic collations. Until then the unit
test for #10230 will be using different default collations in the
equality predicate to test the fix.
@natalya-aksman natalya-aksman added manual-backport and removed auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) labels Jul 10, 2026
@timescale-automation

Copy link
Copy Markdown
Member

Automated backport to 2.28.x not done: cherry-pick failed.

Git status

HEAD detached at origin/2.28.x
You are currently cherry-picking commit 656740b25.
  (all conflicts fixed: run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

nothing to commit, working tree clean

Job log

@timescale-automation timescale-automation added the auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) label Jul 14, 2026
@timescale-automation timescale-automation added the released-2.29.0 Released in 2.29.0 label Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) bug manual-backport released-2.29.0 Released in 2.29.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants