Stabilize unit test for collation fix in PR10230 - #10239
Merged
natalya-aksman merged 1 commit intoJul 9, 2026
Merged
Conversation
|
@dbeck, @melihmutlu: please review this pull request.
|
natalya-aksman
requested review from
Poroma-Banerjee,
akuzm and
dbeck
and removed request for
dbeck and
melihmutlu
July 8, 2026 17:37
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
akuzm
approved these changes
Jul 8, 2026
dbeck
approved these changes
Jul 8, 2026
natalya-aksman
force-pushed
the
stabilize_unit_test_for_collation_fix_in_10230
branch
from
July 9, 2026 12:13
3bc3c05 to
e82cebb
Compare
Member
|
Automated backport to 2.28.x not done: cherry-pick failed. Git status |
natalya-aksman
added a commit
that referenced
this pull request
Jul 9, 2026
…PR10230 (#10239) (#10244) Disable-check: force-changelog-file We need to reliably build CI configurations with ICU support before we can test ICU-provided non-deterministic collations. Until then the unit test for #10230 will be using different default collations in the equality predicate to test the fix.
Member
|
Automated backport to 2.28.x not done: cherry-pick failed. Git status |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable-check: force-changelog-file
We need to reliably build CI configurations with ICU support before we can test ICU-provided non-deterministic collations. Until then the unit test for #10230 will be using different default collations in the equality predicate to test the fix.