Build PostgreSQL with ICU on Ubuntu - #10260
Open
natalya-aksman wants to merge 1 commit into
Open
Conversation
|
@melihmutlu, @antekresic: please review this pull request.
|
natalya-aksman
requested review from
Poroma-Banerjee,
akuzm and
svenklemm
and removed request for
antekresic and
melihmutlu
July 14, 2026 18:34
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
akuzm
reviewed
Jul 14, 2026
| cd ~/$PG_SRC_DIR | ||
| ./configure --prefix=$HOME/$PG_INSTALL_DIR --with-openssl \ | ||
| --without-readline --without-zlib --without-libxml ${{ matrix.pg_extra_args }} | ||
| --without-readline --without-zlib --without-libxml --with-icu ${{ matrix.pg_extra_args }} |
Member
There was a problem hiding this comment.
gh_matrix_builder.py also defines --without-icu, so might be better to move it there, to at least centralize this in one place.
Member
Author
There was a problem hiding this comment.
We also have --without-icu defined in linux-32bit-build-and-test.yaml.
It may be easier to limit the scope of application of --with-icu to specific place as gh_matrix_builder.py configs get included in many places?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build PostgreSQL with ICU support on Linux platform so that we can test nondeterministic collations.
Disable-check: force-changelog-file