Support ON CONFLICT DO SELECT on hypertables - #10279
Merged
Merged
Conversation
|
@kpan2034, @melihmutlu: please review this pull request.
|
svenklemm
changed the title
svenklemm
force-pushed
the
sven/pg19_do_select
branch
2 times, most recently
from
July 16, 2026 20:45
8b85faf to
0317fda
Compare
antekresic
approved these changes
Jul 23, 2026
antekresic
left a comment
antekresic
left a comment
Member
There was a problem hiding this comment.
Might be nice to add a test that shows this doesn't trigger DML decompression, making that fact more explicit in the test output.
Otherwise, LGTM.
| * Returns true if we're done (with or without a select), or false if the | ||
| * caller must retry the INSERT from scratch. | ||
| * | ||
| * copied and modified version of ExecOnConflictSelect from |
Member
There was a problem hiding this comment.
its not evident what was modified from the PG version, should we make that more clear?
dbeck
approved these changes
Jul 29, 2026
svenklemm
force-pushed
the
sven/pg19_do_select
branch
4 times, most recently
from
July 31, 2026 15:31
e128c69 to
b3c2a35
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
svenklemm
force-pushed
the
sven/pg19_do_select
branch
from
July 31, 2026 15:46
b3c2a35 to
48b5b32
Compare
PostgreSQL 19 added INSERT ... ON CONFLICT DO SELECT, which returns the conflicting row instead of updating it and can optionally lock it. Upstream changes: Add support for INSERT ... ON CONFLICT DO SELECT. postgres/postgres@88327092ff0
svenklemm
force-pushed
the
sven/pg19_do_select
branch
from
July 31, 2026 15:56
48b5b32 to
ca76727
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL 19 adds INSERT ... ON CONFLICT DO SELECT, which returns the
conflicting row instead of updating it and can optionally lock it.
Upstream PostgreSQL commit:
postgres/postgres@8832709