Propagate vacuum to compressed relation when running on chunk - #10288
Merged
Conversation
|
@melihmutlu, @dbeck: please review this pull request.
|
svenklemm
changed the title
When VACUUM or ANALYZE was run on a single chunk the compressed relation belonging to that chunk was not processed. Add the compressed relation to the list of relations to vacuum when the target is a compressed chunk.
svenklemm
force-pushed
the
sven/compressed_vacuum
branch
from
July 17, 2026 14:07
0941298 to
a111b4c
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
akuzm
reviewed
Jul 17, 2026
| if (chunk && ts_chunk_is_compressed(chunk)) | ||
| { | ||
| Oid compressed_relid = ts_relation_get_compressed_relid(chunk->fd.relid); | ||
| /* Compressed chunk might be missing due to concurrent operations */ |
Member
There was a problem hiding this comment.
Does this mean we also need to lock the relation itself?
Member
There was a problem hiding this comment.
The lookup apparently locks the settings tuple, but I'm not sure if the lock is kept or if it's sufficient, and the "rebuild if needed" uses NoLock.
akuzm
approved these changes
Jul 17, 2026
natalya-aksman
approved these changes
Jul 20, 2026
svenklemm
added
the
force-auto-backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When VACUUM or ANALYZE was run on a single chunk the compressed
relation belonging to that chunk was not processed. Add the
compressed relation to the list of relations to vacuum when the
target is a compressed chunk.
Fixes: #10286