Disable direct compress when RETURNING clause references system columns - #10322
Merged
Conversation
|
@kpan2034, @dbeck: please review this pull request.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
antekresic
approved these changes
Jul 27, 2026
dbeck
approved these changes
Jul 27, 2026
svenklemm
added
the
force-auto-backport
Direct compress stores the tuple in compressed form instead of a regular heap tuple, so system columns like ctid or xmin never get a meaningful value. Fall back to the normal insert path when RETURNING references them. tableoid is fine because the returning projection sets it explicitly.
svenklemm
force-pushed
the
sven/returning_systemcolumns
branch
from
July 27, 2026 12:22
3545ecf to
0e5b9c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct compress stores the tuple in compressed form instead of a
regular heap tuple, so system columns like ctid or xmin never get a
meaningful value. Fall back to the normal insert path when RETURNING
references them. tableoid is fine because the returning projection
sets it explicitly.
Fixes: #10317
Disable-check: force-changelog-file