Backport to 2.29.x: #10339: Fix crash when deleting from compressed cagg source - #10350
Merged
Conversation
Deleting whole batches from a compressed hypertable that has a continuous aggregate needs the time range of each deleted batch to record the aggregate invalidation. It read that range from the min and max metadata of the time column unless the time column is a segmentby column. When the time column was neither segmentby nor orderby invalidation for direct batch delete would crash. Add proper error handling when time column is neither segmentby nor orderby. (cherry picked from commit 56f1656)
timescale-automation
added
the
is-auto-backport
timescale-automation
enabled auto-merge (rebase)
July 28, 2026 15:28
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated backport of #10339: Fix crash when deleting from compressed cagg source.
The original issue is #10259.
This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore.
For more details, please see the documentation
Original description
Fix crash when deleting from compressed cagg source
Deleting whole batches from a compressed hypertable that has a
continuous aggregate needs the time range of each deleted batch to
record the aggregate invalidation. It read that range from the min and
max metadata of the time column unless the time column is a segmentby
column. When the time column was neither segmentby nor orderby
invalidation for direct batch delete would crash. Add proper error
handling when time column is neither segmentby nor orderby and
automatically add time column to orderby when it gets removed from
segmentby in an ALTER statement.
Fixes#10259