Internalize snapshot in decompress_batches_scan - #10353
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
decompress_batches_scan now owns its snapshot lifecycle. It creates, registers, and unregisters the snapshot internally based on cmd_type, removing Push/Pop from callers and the snapshot parameter from the signature.
Poroma-Banerjee
force-pushed
the
tscompress
branch
from
July 29, 2026 03:27
6c061a0 to
804aafa
Compare
svenklemm
approved these changes
Jul 30, 2026
akuzm
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decompress_batches_scan now owns its snapshot lifecycle. It creates, registers, and unregisters the snapshot internally based on cmd_type, removing Push/Pop from callers and the snapshot parameter from the signature.
Needed for upcoming rescanning PR which will be for decompress_batches_scan. #10354
Disable-check: force-changelog-file