Fix crashes with malformed compressed data - #10360
Open
dbeck wants to merge 1 commit into
Open
Conversation
|
@melihmutlu, @svenklemm: please review this pull request.
|
dbeck
force-pushed
the
dbeck/cve_fixes
branch
2 times, most recently
from
July 29, 2026 18:40
4529c6f to
94cb6cd
Compare
akuzm
reviewed
Jul 29, 2026
akuzm
reviewed
Jul 29, 2026
akuzm
reviewed
Jul 29, 2026
akuzm
reviewed
Jul 29, 2026
dbeck
force-pushed
the
dbeck/cve_fixes
branch
3 times, most recently
from
July 29, 2026 19:20
b058b38 to
e536225
Compare
svenklemm
reviewed
Jul 29, 2026
dbeck
force-pushed
the
dbeck/cve_fixes
branch
9 times, most recently
from
July 30, 2026 16:13
f6bdb88 to
d759ebf
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
dbeck
force-pushed
the
dbeck/cve_fixes
branch
3 times, most recently
from
July 30, 2026 16:58
26e9840 to
99992d1
Compare
dbeck
force-pushed
the
dbeck/cve_fixes
branch
15 times, most recently
from
August 2, 2026 10:36
e6cbac2 to
7d64574
Compare
dbeck
changed the title
The Gorilla and Dictionary compressors crashed on malformed data with the reverse decompression iterator and the bulk decompressor. This issue was reported by Mehmet Ince @mdisec https://mehmetince.net/, and the test case binaries are his contribution that I integrated into the fuzzer test suite. This change adds validation for these cases and adds reverse iterator coverage to the fuzzer tests, so the randomised test will catch future issues. It already caught issues in other compressors like deltadelta, which I also fixed in this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Gorilla and Dictionary compressors crashed on malformed data with the reverse decompression iterator and the bulk decompressor.
This issue was reported by Mehmet Ince @mdisec https://mehmetince.net/, and the test case binaries are his contribution that I integrated into the fuzzer test suite.
This change adds validation for these cases and adds reverse iterator coverage to the fuzzer tests, so the randomised test will catch future issues. It already caught issues in other compressors like deltadelta, which I also fixed in this review.