Remove wrong assertion in interpolate lookup - #10399
Open
JoongHyuk-Shin wants to merge 1 commit into
Open
Conversation
|
@svenklemm, @melihmutlu: please review this pull request.
|
interpolate() declares its prev and next parameters as RECORD, which accepts any composite value, including one of a named composite type. The lookup path asserted that the fetched sample always carries the anonymous RECORD type id, so passing a named composite aborts the backend in assertion-enabled builds. The assertion contradicts the call it precedes: the type id and typmod are passed to lookup_rowtype_tupdesc(), which resolves named composite types as well, and the element types are validated right afterwards. The same pattern is used without an assertion in compression.c.
JoongHyuk-Shin
force-pushed
the
fix/gapfill-interpolate-composite-assert
branch
from
August 4, 2026 01:34
a35a715 to
8ef8e46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
interpolate() declares its prev and next parameters as RECORD, which accepts any composite value, including one of a named composite type. The lookup path asserted that the fetched sample always carries the anonymous RECORD type id, so passing a named composite aborts the backend in assertion-enabled builds.
The assertion contradicts the call it precedes: the type id and typmod are passed to lookup_rowtype_tupdesc(), which resolves named composite types as well, and the element types are validated right afterwards. The same pattern is used without an assertion in compression.c.