Close a gap in tracking writer/flusher sync - #10453
Open
pnthao wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
pnthao
force-pushed
the
thao/granular_refresh_writer_gap
branch
from
August 13, 2026 19:31
ab8e4f1 to
705c642
Compare
Demonstrate that there could be cases when an interrupted tracking writer (DML) can leave num_writers positive forever, blocking future flusher (refresh).
There used to be a small window where a tracking writer (DML) failed to decrease num_writer on failure exit. This commit fixes the issue by making sure ts_tenant_tracker_end_batch is called during transaction abort events.
Move the pin release during abort to before the early return block, and add some asserts to guard against possible changes that could invalidate current assumptions about where/when a generation gets pinned/unpinned
pnthao
force-pushed
the
thao/granular_refresh_writer_gap
branch
from
August 31, 2026 19:38
705c642 to
0fa520f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close a gap in tracking writer/flusher sync
I will merge into one commit before merging. Separating reproducers from the fix now so it's easier to review.
Disable-check: force-changelog-file