Skip to content

Fix matching NULL tuples to compressed batches with NULL boundaries for recompress - #10506

Open
natalya-aksman wants to merge 1 commit into
mainfrom
fix_matching_null_uncompressed_tuples_to_compressed_tuple_boundaries_for_recompress
Open

Fix matching NULL tuples to compressed batches with NULL boundaries for recompress#10506
natalya-aksman wants to merge 1 commit into
mainfrom
fix_matching_null_uncompressed_tuples_to_compressed_tuple_boundaries_for_recompress

Conversation

@natalya-aksman

@natalya-aksman natalya-aksman commented Aug 26, 2026

Copy link
Copy Markdown
Member

Fixes #10400.

We need to properly match NULL uncompressed tuples to compressed batches with NULL boundaries.

@github-actions

Copy link
Copy Markdown

@antekresic, @svenklemm: please review this pull request.

Powered by pull-review

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tsl/src/compression/recompress.c 88.88% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@natalya-aksman
natalya-aksman force-pushed the fix_matching_null_uncompressed_tuples_to_compressed_tuple_boundaries_for_recompress branch 2 times, most recently from c26887c to b9f74cd Compare August 26, 2026 16:33
@natalya-aksman natalya-aksman added this to the v2.30.0 milestone Aug 26, 2026
@natalya-aksman natalya-aksman added the Columnstore Related to the column store / compression label Aug 26, 2026
Comment thread tsl/src/compression/recompress.c Outdated
Comment thread tsl/src/compression/recompress.c
Comment thread tsl/src/compression/recompress.c Outdated
@natalya-aksman
natalya-aksman force-pushed the fix_matching_null_uncompressed_tuples_to_compressed_tuple_boundaries_for_recompress branch from b9f74cd to 83cc3df Compare August 27, 2026 14:09
@natalya-aksman
natalya-aksman force-pushed the fix_matching_null_uncompressed_tuples_to_compressed_tuple_boundaries_for_recompress branch from 83cc3df to 971bb08 Compare August 27, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Columnstore Related to the column store / compression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

overlapping batches after recompression with nullable multi-column DESC NULLS FIRST orderby

2 participants