Update compression stats when merging chunks #7909
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erimatnor
force-pushed
the
update-compression-stats-on-merge-chunks
branch
2 times, most recently
from
eb21756 to
f33b3c9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7909 +/- ##
==========================================
+ Coverage 80.06% 81.88% +1.81%
==========================================
Files 190 249 +59
Lines 37181 46177 +8996
Branches 9450 11575 +2125
==========================================
+ Hits 29770 37813 +8043
- Misses 2997 3801 +804
- Partials 4414 4563 +149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
erimatnor
force-pushed
the
update-compression-stats-on-merge-chunks
branch
from
f33b3c9 to
13a19e7
Compare
Merge compression chunk size stats when merging chunks. The merged chunk's stats is simply the sum of the stats of all compressed chunks that are merged. This ensures that the aggregate stats do not change due to the merge. Still, the stats might not accurately represent the merged chunk since merging both compressed and non-compressed chunks will leave some data uncompressed and this data won't be reflected in the stats of the merged chunk.
erimatnor
force-pushed
the
update-compression-stats-on-merge-chunks
branch
from
13a19e7 to
1c375af
Compare
mkindahl
approved these changes
Apr 9, 2025
| TupleInfo *ti = ts_scan_iterator_tuple_info(&iterator); | ||
| bool should_free; | ||
| HeapTuple tuple = ts_scanner_fetch_heap_tuple(ti, false, &should_free); | ||
| memcpy(form, GETSTRUCT(tuple), sizeof(FormData_compression_chunk_size)); |
There was a problem hiding this comment.
Nit: Will avoid problems if the type of form changes.
Suggested change
| memcpy(form, GETSTRUCT(tuple), sizeof(FormData_compression_chunk_size)); | |
| memcpy(form, GETSTRUCT(tuple), sizeof(*form)); |
Comment on lines
+286
to
+292
| select * from _timescaledb_catalog.compression_chunk_size order by chunk_id; | ||
| chunk_id | compressed_chunk_id | uncompressed_heap_size | uncompressed_toast_size | uncompressed_index_size | compressed_heap_size | compressed_toast_size | compressed_index_size | numrows_pre_compression | numrows_post_compression | numrows_frozen_immediately | ||
| ----------+---------------------+------------------------+-------------------------+-------------------------+----------------------+-----------------------+-----------------------+-------------------------+--------------------------+---------------------------- | ||
| 1 | 6 | 8192 | 0 | 32768 | 16384 | 8192 | 16384 | 1 | 1 | 1 | ||
| 3 | 7 | 8192 | 0 | 32768 | 16384 | 8192 | 16384 | 1 | 1 | 1 | ||
| (2 rows) | ||
|
|
There was a problem hiding this comment.
You might want to use \x on for these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge compression chunk size stats when merging chunks. The merged chunk's stats is simply the sum of the stats of all compressed chunks that are merged. This ensures that the aggregate stats do not change due to the merge. Still, the stats might not accurately represent the merged chunk since merging both compressed and non-compressed chunks will leave some data uncompressed and this data won't be reflected in the stats of the merged chunk.