Allow custom names for User-Defined Actions

[melihmutlu]

This commit allows custom names for Used-Defined Actions.

add_job() and alter_job() accept an additional "job_name" argument to modify the name of User-Defined Action. If "job_name" is not specified, it is names as default.

Closes #6991

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[RobAtticus]

Nice, so this would close #6991 then?

[mkindahl]

Patch looks good, but I do not think it is necessary to add the job id if the user provides a job name.

It forces the user to think about this when reading job information using scripts or automation and also limits the usability for the user if they want to provide other information or information in different format as part of the job name.

[codecov]

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.13%. Comparing base (59f50f2) to head (423fad7).
Report is 907 commits behind head on main.

Files with missing lines	Patch %	Lines
tsl/src/bgw_policy/job_api.c	84.61%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7958      +/-   ##
==========================================
+ Coverage   80.06%   82.13%   +2.06%     
==========================================
  Files         190      250      +60     
  Lines       37181    46299    +9118     
  Branches     9450    11620    +2170     
==========================================
+ Hits        29770    38026    +8256     
- Misses       2997     3668     +671     
- Partials     4414     4605     +191     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[svenklemm]

Shouldn't the datatype in the API be text since name is for sql identifier which this is not.

[melihmutlu]

Shouldn't the datatype in the API be text since name is for sql identifier which this is not.

application_name is name, and job names go into application_name. That's why I decided to go with name instead of text.

Another reason was thatname has a limit of 63 bytes, so it would help to have names with reasonable lengths. But now I realize that a format like "<job_name> [<job_id>]" can easily exceed that limit. Even without appending the job ID, users could provide long job names that get truncated to 63 bytes, potentially resulting in different jobs ending up with the same name.

Maybe we should have a limit on the length of job name, possibly a bit shorter than 63, to be safe. Any thoughts?