Add vectorized filtering to constraint checking #7972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antekresic
added
the
enhancement
When backfilling compressed chunks with constraint checking, we need to read and filter compressed tuples in order to confirm constraints are validated. This change adds the ability to do this operation using vectorized decompression and vectorized filtering if the types allow us to do so.
antekresic
force-pushed
the
antekresic/add_vectorized_filtering
branch
from
3357ca6 to
2b51915
Compare
akuzm
reviewed
Apr 16, 2025
Comment on lines
+425
to
+426
| BatchMatcher *batch_matcher = | ||
| constraints && constraints->vectorized_filtering ? batch_matches_vectorized : batch_matches; |
There was a problem hiding this comment.
Is it complicated to do both at the same time? DecompressChunk does this, some filters can be vectorized and some not, and both are supported at the same time.
akuzm
reviewed
Apr 16, 2025
| continue; | ||
| } | ||
|
|
||
| VectorPredicate *predicate = get_vector_const_predicate(scankeys[sk].sk_func.fn_oid); |
There was a problem hiding this comment.
Is it possible to use vector_qual_make + vector_qual_compute? This will be difficult to maintain, right now we're adding bools here, and then UUIDs, and it looks like it might require separate support here. An example of how this is used is in can_vectorize_aggref + vector_agg_exec.
akuzm
reviewed
Apr 16, 2025
Comment on lines
+1654
to
+1656
| /* Ignore segmentby columns, they aren't compressed */ | ||
| if (ts_array_is_member(settings->fd.segmentby, attname)) | ||
| continue; |
There was a problem hiding this comment.
vector_qual_compute works for segmentby as well, we use that when computing FILTER clause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When backfilling compressed chunks with constraint checking, we need to read and filter compressed tuples in order to confirm constraints are validated. This change adds the ability to do this operation using vectorized decompression and vectorized filtering if the types allow us to do so.