Skip to content

Include cagg name in timescaledb_information.jobs #7976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

melihmutlu
Copy link

@melihmutlu melihmutlu commented Apr 16, 2025

In the timescaledb_information.jobs view, it is not possible to see the
continuous aggregate name for jobs related to continuous aggregates and
it is necessary to use the materialized table id to look up the actual
continuous aggregate. Since hypertable_schema and hypertable_name
columns contain the materialized hypertable for the continuous
aggregate, which are considered internal objects and not very useful
except for looking up the continuous aggregate, we store the continuous
aggregate name and schema in these columns.

@melihmutlu melihmutlu force-pushed the cagg_name_jobs branch 4 times, most recently from 0053e99 to db75c01 Compare April 16, 2025 19:54
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (59f50f2) to head (95b3f46).
Report is 907 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7976      +/-   ##
==========================================
+ Coverage   80.06%   82.14%   +2.07%     
==========================================
  Files         190      250      +60     
  Lines       37181    46284    +9103     
  Branches     9450    11613    +2163     
==========================================
+ Hits        29770    38021    +8251     
- Misses       2997     3662     +665     
- Partials     4414     4601     +187     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melihmutlu melihmutlu force-pushed the cagg_name_jobs branch 3 times, most recently from abee5d3 to bbe3458 Compare April 16, 2025 20:19
@melihmutlu melihmutlu added Background Worker The background worker subsystem, including the scheduler jobs labels Apr 16, 2025
@philkra philkra added this to the v2.20.0 milestone Apr 17, 2025
@melihmutlu melihmutlu force-pushed the cagg_name_jobs branch 2 times, most recently from 25a42ed to 871fd95 Compare April 17, 2025 22:07
@melihmutlu melihmutlu requested a review from mkindahl April 17, 2025 22:07
@mkindahl
Copy link
Contributor

This seems to be implemented in #7976.

@mkindahl
Copy link
Contributor

mkindahl commented Apr 22, 2025

For jobs that belong to a continuous aggreagate, use cagg name and cagg schema in timescaledb_information.jobs view instead of internal hypertable name and schema.

Might be better to spell out details and avoid abbreviations, e.g., something along these lines (I usually elaborate a lot in my comments since I find it useful when you want to figure out why you did something as well as what you did, but you don't have to do that).

Updated:

In the timescaledb_information.jobs view, it is not possible to see the continuous aggregate name for jobs related to continuous aggregates and it is necessary to use the materialized table id to look up the actual continuous aggregate. Since hypertable_schema and hypertable_name columns contain the materialized hypertable for the continuous aggregate, which are considered internal objects and not very useful except for looking up the continuous aggregate, we store the continuous aggregate name and schema in these columns.

In the timescaledb_information.jobs view, it is not possible to see the
continuous aggregate name for jobs related to continuous aggregates and
it is necessary to use the materialized table id to look up the actual
continuous aggregate. Since hypertable_schema and hypertable_name
columns contain the materialized hypertable for the continuous
aggregate, which are considered internal objects and not very useful
except for looking up the continuous aggregate, we store the continuous
aggregate name and schema in these columns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Background Worker The background worker subsystem, including the scheduler jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants