Support ALTER TABLE SET (tsdb.chunk_time_interval='1 day') #8005
Conversation
|
@fabriziomello, @akuzm: please review this pull request.
|
| @@ -292,3 +292,18 @@ SELECT count(*) FROM test_output; | |||
| 2 | |||
| (1 row) | |||
|
|
|||
| -- test ALTER TABLE SET (tsdb.chunk_time_interval) on a hypertable | |||
| CREATE TABLE t_with(time timestamptz not null, device text, value float) WITH (tsdb.hypertable,tsdb.time_column='time'); | |||
There was a problem hiding this comment.
Would be good to also include a test using tsdb.chunk_time_interval in CREATE TABLE
There was a problem hiding this comment.
This PR only adds ALTER TABLE stuff, for CREATE TABLE there are already multiple tests in tsl/test/sql/create_table_with.sql
| @@ -15,7 +15,8 @@ | |||
|
|
|||
| typedef enum AlterTableFlags | |||
| { | |||
| AlterTableFlagCompressEnabled = 0, | |||
| AlterTableFlagChunkTimeInterval = 0, | |||
There was a problem hiding this comment.
Why do we have = 0 by the way? Looks as if we cared about the absolute values, but we don't.
There was a problem hiding this comment.
since those are used as array index we want them to start with 0 to align with array size
There was a problem hiding this comment.
but those values are never persisted so it's not required that they stay in same order
svenklemm
force-pushed
the
sven/set_chunk_time_interval
branch
from
23a8c11 to
e68b75a
Compare
No description provided.