Fix compression policy error message. #8008
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8008 +/- ##
==========================================
+ Coverage 80.06% 82.19% +2.13%
==========================================
Files 190 252 +62
Lines 37181 46498 +9317
Branches 9450 11688 +2238
==========================================
+ Hits 29770 38221 +8451
- Misses 2997 3639 +642
- Partials 4414 4638 +224 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@gayyappan I'm thinking if we should provide a way to fix the wrong error messages on |
|
Another thing that bother me is that we don't have a proper regression test for it, or do we have? |
fabriziomello
force-pushed
the
try
branch
4 times, most recently
from
f6d3d74 to
6053417
Compare
fabriziomello
force-pushed
the
try
branch
3 times, most recently
from
6e3415d to
385d6fe
Compare
Co-authored-by: Fabrízio de Royes Mello <[email protected]>
Added regression tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of successes was calculated incorrectly.