Strip whitespace when checking query results in TAP tests #8048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkindahl, @fabriziomello: please review this pull request.
|
svenklemm
force-pushed
the
sven/tap_whitespace
branch
6 times, most recently
from
29595f5 to
8e0dc4a
Compare
|
Fix for whitespace related TAP failures, e.g. https://github.com/timescale/timescaledb/actions/runs/14805376804/job/41572671580 |
svenklemm
force-pushed
the
sven/tap_whitespace
branch
from
8e0dc4a to
4b3750c
Compare
| @@ -97,10 +93,8 @@ | |||
|
|
|||
| # Begin txns in both sessions | |||
| $result = $s1->query_safe("BEGIN"); | |||
| isnt($result, '', "session 1: begin"); | |||
There was a problem hiding this comment.
why removing those isnt?? isn't it part of the necessary checks for this tap test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable-check: force-changelog-file