Remove wrong assertion in first/last initplan optimization - #9724
Merged
Conversation
It did not correctly handle the case of SELECT FROM ONLY hypertable. Besides that, the code that restored RangeTblEntry.inh was targeting the wrong PlannerInfo -- the one from original query instead of the copy used for the optimization. Remove this code as well, since it doesn't do anything useful.
|
@pnthao, @dbeck: please review this pull request.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
dbeck
approved these changes
May 6, 2026
natalya-aksman
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It did not correctly handle the case of SELECT FROM ONLY hypertable.
Besides that, the code that restored RangeTblEntry.inh was targeting the wrong PlannerInfo -- the one from original query instead of the copy used for the optimization. Remove this code as well, since it doesn't do anything useful.
Part of #9714
Disable-check: force-changelog-file