Fixing composite bloom filter column naming - #9759
Merged
Merged
Conversation
As reported in issue #9578, there was a case when concatenating two columns could create overlapping results. For example ('a_b','c') and ('a','b_c') resulted the same composite bloom metadata column name. This caused an error during the compression of the chunk. This change modifies the column naming scheme for composite bloom columns and thus eliminates the issue. Fixes: #9578
svenklemm
approved these changes
May 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in issue #9578, there was a case when concatenating two
columns could create overlapping results. For example ('a_b','c') and
('a','b_c') resulted the same composite bloom metadata column name.
This caused an error during the compression of the chunk.
This change modifies the column naming scheme for composite bloom
columns and thus eliminates the issue.
Fixes: #9578