Remove outdated workaround from columnar sort planning - #9809
Merged
Conversation
We used to have a workaround there that added cost to account for projection needed by Sort node. It proved to be more harmful than useful, so it was removed, but some code was left over. Remove it too.
|
@kpan2034, @natalya-aksman: please review this pull request.
|
natalya-aksman
approved these changes
May 13, 2026
antekresic
approved these changes
May 15, 2026
… ordered_append_join transparent_decompress_chunk
…ordered_append_join transparent_decompress_chunk
…ordered_append_join transparent_decompress_chunk
…onstraint_exclusion_prepared ordered_append_join transparent_decompress_chunk
…constraint_exclusion_prepared ordered_append_join transparent_decompress_chunk
…hunk columnar_index_scan ordered_append_join
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
akuzm
enabled auto-merge (squash)
June 22, 2026 08:14
kpan2034
pushed a commit
to kpan2034/timescaledb
that referenced
this pull request
Jul 1, 2026
We used to have a workaround there that added cost to account for projection needed by Sort node. It proved to be more harmful than useful, so it was removed, but some code was left over. Remove it too. The main part removed here: timescale#8416 This leads to some 6x speedups on some queries to partially compressed tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to have a workaround there that added cost to account for projection needed by Sort node. It proved to be more harmful than useful, so it was removed, but some code was left over. Remove it too.
The main part removed here: #8416
This leads to some 6x speedups on some queries to partially compressed tables: https://grafana.dev-us-east-1.ops.dev.timescale.com/d/fasYic_4z/compare-benchmark-runs?orgId=1&var-run1=5657&var-run2=5658&var-postgres=16&var-branch=All&var-threshold=0.02&var-use_historical_thresholds=true&var-threshold_expression=2.0%20%2A%20percentile_cont%280.90%29&var-exact_suite_version=true
Disable-check: force-changelog-file