Defer initialization of child plan states in ModifyHypertable node

[akuzm]

The underlying scans must be initialized after we decompress the data potentially affected by DML operations, so that the scans see this data. At the moment we're restarting the scans after decompression, but this is not the proper Postgres protocol, so it breaks.

Fixes #9913

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[github-actions]

@Poroma-Banerjee, @dbeck: please review this pull request.

Powered by pull-review

[antekresic]

Great improvement, glad to have the workaround removed 🎉

[timescale-automation]

Automated backport to 2.28.x not done: cherry-pick failed.

Git status

HEAD detached at origin/2.28.x
You are currently cherry-picking commit 9636ef2bd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .unreleased/dml-bitmap-crash
	modified:   src/nodes/modify_hypertable.c
	modified:   src/nodes/modify_hypertable.h
	modified:   src/nodes/modify_hypertable_exec.c
	modified:   tsl/src/compression/compression_dml.c
	modified:   tsl/src/planner.c
	new file:   tsl/test/expected/compress_dml_aux.out
	new file:   tsl/test/expected/compress_dml_bitmap_rescan.out
	deleted:    tsl/test/expected/compression_delete_bitmapscan-16.out
	deleted:    tsl/test/expected/compression_delete_bitmapscan-18.out
	renamed:    tsl/test/expected/compression_delete_bitmapscan-17.out -> tsl/test/expected/compression_delete_bitmapscan.out
	modified:   tsl/test/expected/compression_update_delete-16.out
	new file:   tsl/test/sql/compress_dml_aux.sql
	new file:   tsl/test/sql/compress_dml_bitmap_rescan.sql
	renamed:    tsl/test/sql/compression_delete_bitmapscan.sql.in -> tsl/test/sql/compression_delete_bitmapscan.sql

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tsl/test/sql/CMakeLists.txt

Job log