Fix debug_refresh_window to use correct min - #9968
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
melihmutlu
marked this pull request as ready for review
June 5, 2026 10:51
|
@akuzm, @kpan2034: please review this pull request.
|
pnthao
approved these changes
Jun 5, 2026
gayyappan
approved these changes
Jun 5, 2026
For timestamp types, the code skipped the internal to timestamp conversion, mis-rendering the minimum by the epoch difference. Use ts_internal_to_time_string() and regenerate cagg_policy_incremental, the only test exercising this debug line. Disable-check: force-changelog-file
melihmutlu
force-pushed
the
debug_line_fix
branch
from
June 5, 2026 14:59
42325d2 to
6250b58
Compare
melihmutlu
enabled auto-merge (squash)
June 5, 2026 15:00
melihmutlu
disabled auto-merge
June 5, 2026 15:09
melihmutlu
enabled auto-merge (squash)
June 5, 2026 15:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For timestamp types, the code skipped the internal to timestamp conversion, mis-rendering the minimum by the epoch difference.
Use ts_internal_to_time_string() and regenerate cagg_policy_incremental, the only test exercising this debug line.
Disable-check: force-changelog-file