Fixed timescaledb loader initialization #255
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point timescaledb's function became more strict, so it failed if 'replication_factor => NULL' part exists. Table initialization method was refactored to fix this issue. Signed-off-by: Koheiru <[email protected]>
|
has anyone merged this fix into the master branch? @Koheiru |
|
Why is this not merged yet? I am having the same issue. |
|
faced the same issue |
evenyag
added a commit
to GreptimeTeam/tsbs
that referenced
this pull request
Dec 5, 2025
Refer to timescale#255 Signed-off-by: evenyag <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point timescaledb's function
create_hypertablebecame more strict and it starts to fail if 'replication_factor => NULL' part exists. In such casetsbs_loadfailed with error:Other users also report about this issue: #248
To fix this issue timescaledb table initialization method was adjusted.