tests: cover Vulkan mesh shader opt-in#162
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Stale comment
Security review complete: no medium, high, or critical vulnerabilities found in the PR changes.
Reviewed the added CTest entry and
tests/scripts/test_vulkan_mesh_shader_opt_in.sh. The new script only reads fixed repository-relative source files and checks expected literals/regexes; I did not find attacker-controlled input flowing to command execution, file writes, network access, secrets, or another security-sensitive sink. No prior automation security-review threads were present to revalidate.Sent by Cursor Automation: Find vulnerabilities
There was a problem hiding this comment.
Security review complete: no medium, high, or critical vulnerabilities found in the current PR diff.
Notes:
- No unresolved prior security-review threads were present to revalidate.
- The advertised base/head trees are identical, so there are no current added or modified diff lines for inline findings.
- The mesh-shader regression script present in the branch was sanity-checked with its expected project-root argument and passed.
Sent by Cursor Automation: Find vulnerabilities


Summary
VK_NV_mesh_shaderVulkan setup.test_vulkan_mesh_shader_opt_inin CTest withunit;scripts;validation;rendererlabels.Risky behavior now covered
r_vk_meshShaderNVremains default-off, latched, range-limited, and documented as restart-required.VK_NV_mesh_shaderis only enabled when the driver advertises it, the user explicitly opts in, and the extension list has capacity.pNextchain.Test files added/updated
tests/scripts/test_vulkan_mesh_shader_opt_in.sh.CMakeLists.txtto register the test with CTest.Why this reduces regression risk
This protects a driver-dependent Vulkan device-creation path that is difficult to exercise in headless CI. The test catches accidental default-on behavior, unsafe extension enabling, missing startup visibility, and
pNextchaining regressions before they can break Vulkan initialization on affected hardware.Validation
tests/scripts/test_vulkan_mesh_shader_opt_in.shcmake -S . -B build-coverage-tests -DBUILD_TESTING=ON -DBUILD_UNIT_TESTS=OFF -DUSE_LUA=OFF -DUSE_DUKTAPE=OFF -DUSE_OPUS=OFF -DUSE_FLAC=OFF -DUSE_WEBM=OFF -DUSE_FLUX=OFF && ctest --test-dir build-coverage-tests -R test_vulkan_mesh_shader_opt_in --output-on-failure