Skip to content

tests: cover Vulkan mesh shader opt-in#162

Merged
timfox merged 2 commits intonext-gen-5from
cursor/regression-test-coverage-960d
May 4, 2026
Merged

tests: cover Vulkan mesh shader opt-in#162
timfox merged 2 commits intonext-gen-5from
cursor/regression-test-coverage-960d

Conversation

@cursor
Copy link
Copy Markdown

@cursor cursor Bot commented Apr 30, 2026

Summary

  • Add deterministic source-level regression coverage for the optional VK_NV_mesh_shader Vulkan setup.
  • Register the new script as test_vulkan_mesh_shader_opt_in in CTest with unit;scripts;validation;renderer labels.

Risky behavior now covered

  • r_vk_meshShaderNV remains default-off, latched, range-limited, and documented as restart-required.
  • VK_NV_mesh_shader is only enabled when the driver advertises it, the user explicitly opts in, and the extension list has capacity.
  • Device feature chaining enables only mesh shaders, keeps task shaders disabled, and preserves the existing pNext chain.

Test files added/updated

  • Added tests/scripts/test_vulkan_mesh_shader_opt_in.sh.
  • Updated CMakeLists.txt to register the test with CTest.

Why this reduces regression risk

This protects a driver-dependent Vulkan device-creation path that is difficult to exercise in headless CI. The test catches accidental default-on behavior, unsafe extension enabling, missing startup visibility, and pNext chaining regressions before they can break Vulkan initialization on affected hardware.

Validation

  • tests/scripts/test_vulkan_mesh_shader_opt_in.sh
  • cmake -S . -B build-coverage-tests -DBUILD_TESTING=ON -DBUILD_UNIT_TESTS=OFF -DUSE_LUA=OFF -DUSE_DUKTAPE=OFF -DUSE_OPUS=OFF -DUSE_FLAC=OFF -DUSE_WEBM=OFF -DUSE_FLUX=OFF && ctest --test-dir build-coverage-tests -R test_vulkan_mesh_shader_opt_in --output-on-failure
Open in Web View Automation 

Co-authored-by: Tim Fox <timfox@outlook.com>
@timfox timfox marked this pull request as ready for review May 4, 2026 23:04
Co-authored-by: Cursor <cursoragent@cursor.com>
@timfox timfox merged commit 5e779e1 into next-gen-5 May 4, 2026
20 of 23 checks passed
Copy link
Copy Markdown
Author

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Security review complete: no medium, high, or critical vulnerabilities found in the PR changes.

Reviewed the added CTest entry and tests/scripts/test_vulkan_mesh_shader_opt_in.sh. The new script only reads fixed repository-relative source files and checks expected literals/regexes; I did not find attacker-controlled input flowing to command execution, file writes, network access, secrets, or another security-sensitive sink. No prior automation security-review threads were present to revalidate.

Open in Web View Automation 

Sent by Cursor Automation: Find vulnerabilities

Copy link
Copy Markdown
Author

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security review complete: no medium, high, or critical vulnerabilities found in the current PR diff.

Notes:

  • No unresolved prior security-review threads were present to revalidate.
  • The advertised base/head trees are identical, so there are no current added or modified diff lines for inline findings.
  • The mesh-shader regression script present in the branch was sanity-checked with its expected project-root argument and passed.
Open in Web View Automation 

Sent by Cursor Automation: Find vulnerabilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants