tests: cover Vulkan mesh shader opt-in#164
Draft
cursor[bot] wants to merge 1 commit intonext-gen-5from
Draft
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VK_NV_mesh_shaderenablement.unit;scripts;validation;renderer.Risky behavior now covered
r_vk_meshShaderNVmust remain default-off, latched, range-limited, and documented as requiringvid_restart.vk.meshShaderNVmust track enablement and the feature chain must request mesh shaders only while leaving task shaders disabled.Test files added/updated
tests/scripts/test_vulkan_mesh_shader_opt_in.shCMakeLists.txtWhy this reduces regression risk
This protects an experimental hardware/driver-facing Vulkan extension path from accidentally becoming enabled by default or bypassing explicit opt-in. The test is source-invariant based, so it runs deterministically in headless CI without requiring Vulkan mesh-shader-capable hardware.
Validation
tests/scripts/test_vulkan_mesh_shader_opt_in.shcmake -S . -B build-coverage-tests -DBUILD_TESTING=ON -DBUILD_UNIT_TESTS=OFFctest --test-dir build-coverage-tests -R test_vulkan_mesh_shader_opt_in --output-on-failure