Renderer cleanup: remove dead if(0) gates and unused r_drawSun#165
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
Renderer cleanup: remove dead if(0) gates and unused r_drawSun#165cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
- Drop permanently disabled r_lightmap==2 HSV debug branch and helper. - Remove unused color-clear experiment gated by if(0&&r_fastsky). - Remove r_drawSun cvar, sun shader lookup, and RB_DrawSun (never reachable). Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes permanently unreachable renderer branches and unused cvar/shader wiring so behavior matches what actually shipped.
Flags / knobs removed
r_drawSunif (0 && r_drawSun->integer)in both Vulkan and OpenGL backends — the cvar had no effect at runtime. Default was already0.r_lightmap == 2HSV visualizationif (0 && r_lightmap->integer == 2)meant that debug path never ran;r_lightmapremains for other uses.if (0 && r_fastsky->integer && ...)never executed;r_fastskyremains for sky rendering paths intr_sky.c/tr_main.c.Also removed dead plumbing only referenced by the removed paths:
tr.sunShader,RB_DrawSun, and the"sun"shader lookup inCreateExternalShaders.Behavioral parity
./scripts/compile_engine.sh vulkan/opengl).ctestfrombuild-vk-Release— all 19 tests passed (smoke, renderer regression check, units).Notes
Saved configs that set
r_drawSunwill ignore that key (harmless). No gameplay or networking impact.